[ 
https://issues.apache.org/jira/browse/HDDS-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemant Kumar updated HDDS-9198:
-------------------------------
    Description: 
After [HDDS-8665|https://issues.apache.org/jira/browse/HDDS-8665], there is a 
possibility that [snapshot 
cache|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R102]
 gets updated but [snapshot chain 
update|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R104]
 fails and leave it in a situation that snapshot's previous snapshot is 
pointing to something which doesn't exist or order is messed.

We need to revisit this and see if there is any race condition issue in 
snapshot purge.

One possible solution is, snapshot purge should be single snapshot purge 
request instead of batch request.
Other thing is we may need locking in snapshot purge request handler.

  was:
After [HDDS-8665|https://issues.apache.org/jira/browse/HDDS-8665], there is a 
possibility that [snapshot 
cache|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R102]
 gets updated but [snapshot chain 
update|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R104]
 fails and leave it in a situation that snapshot's previous snapshot is 
pointing to something which doesn't exist or order is messed.

We need to revisit this and see if there is any race condition issue in 
snapshot purge.

One possible solution it, snapshot purge should be single snapshot purge 
request instead of batch request.
Other thing is we may need locking in snapshot purge request handler.


> Snapshot purge should be a atomic operation
> -------------------------------------------
>
>                 Key: HDDS-9198
>                 URL: https://issues.apache.org/jira/browse/HDDS-9198
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Hemant Kumar
>            Priority: Major
>
> After [HDDS-8665|https://issues.apache.org/jira/browse/HDDS-8665], there is a 
> possibility that [snapshot 
> cache|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R102]
>  gets updated but [snapshot chain 
> update|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R104]
>  fails and leave it in a situation that snapshot's previous snapshot is 
> pointing to something which doesn't exist or order is messed.
> We need to revisit this and see if there is any race condition issue in 
> snapshot purge.
> One possible solution is, snapshot purge should be single snapshot purge 
> request instead of batch request.
> Other thing is we may need locking in snapshot purge request handler.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to