adoroszlai commented on code in PR #5660:
URL: https://github.com/apache/ozone/pull/5660#discussion_r1460413375
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -682,6 +697,24 @@ private void audit(AuditAction action, EventType eventType,
}
}
+ private void performanceAudit(AuditAction action, Map<String, String> params,
+ PerformanceStringBuilder performance) {
+ AuditMessage msg =
+ buildAuditMessageForPerformance(action, params, performance.build());
+ AUDIT.logPerformance(msg);
+ }
+
+ public AuditMessage buildAuditMessageForPerformance(AuditAction op,
+ Map<String, String> auditMap, String performance) {
Review Comment:
`AuditMessage` takes `PerformanceStringBuilder` directly (after HDDS-9822):
```suggestion
Map<String, String> auditMap, PerformanceStringBuilder performance) {
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -873,6 +910,8 @@ private static Map<String, String> getAuditParams(
auditParams.put("blockData",
BlockData.getFromProtoBuf(msg.getPutSmallFile()
.getBlock().getBlockData()).toString());
+ auditParams.put("blockDataSize",
+ String.valueOf(msg.getReadChunk().getChunkData().getLen()));
Review Comment:
```suggestion
String.valueOf(msg.getPutSmallFile().getChunkData().getLen()));
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -857,6 +892,8 @@ private static Map<String, String> getAuditParams(
auditParams.put("blockData",
BlockID.getFromProtobuf(msg.getWriteChunk().getBlockID())
.toString());
+ auditParams.put("blockDataSize",
+ String.valueOf(msg.getReadChunk().getChunkData().getLen()));
Review Comment:
```suggestion
String.valueOf(msg.getWriteChunk().getChunkData().getLen()));
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -885,6 +924,8 @@ private static Map<String, String> getAuditParams(
auditParams.put("blockData",
BlockID.getFromProtobuf(msg.getGetSmallFile().getBlock().getBlockID())
.toString());
+ auditParams.put("blockDataSize",
+ String.valueOf(msg.getReadChunk().getChunkData().getLen()));
Review Comment:
```suggestion
String.valueOf(msg.getGetSmallFile().getChunkData().getLen()));
```
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/audit/AuditLogger.java:
##########
@@ -155,6 +160,22 @@ public void appendOpLatencyNanos(long nanos) {
append("opLatencyMs", TimeUnit.NANOSECONDS.toMillis(nanos));
}
+ /**
+ * Appends pre-operation operation latency in milliseconds.
+ * @param millis Latency in nanoseconds.
+ */
+ public void appendPreOpLatencyMs(long millis) {
+ append("preOpLatencyMs", TimeUnit.NANOSECONDS.toMillis(millis));
Review Comment:
Name and param say "millis", but conversion is from nanos.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -682,6 +697,24 @@ private void audit(AuditAction action, EventType eventType,
}
}
+ private void performanceAudit(AuditAction action, Map<String, String> params,
+ PerformanceStringBuilder performance) {
+ AuditMessage msg =
+ buildAuditMessageForPerformance(action, params, performance.build());
Review Comment:
Also related to HDDS-9822:
```suggestion
buildAuditMessageForPerformance(action, params, performance);
```
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/audit/AuditMarker.java:
##########
@@ -25,7 +25,8 @@
public enum AuditMarker {
WRITE(MarkerManager.getMarker("WRITE")),
READ(MarkerManager.getMarker("READ")),
- AUTH(MarkerManager.getMarker("AUTH")),;
+ AUTH(MarkerManager.getMarker("AUTH")),
+ PERFORMANCE(MarkerManager.getMarker("PERFORMANCE"));
Review Comment:
What is the intended use of this marker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
