adoroszlai opened a new pull request, #6051: URL: https://github.com/apache/ozone/pull/6051
## What changes were proposed in this pull request? Revert HDDS-9426 because it introduced incompatible proto changes (https://github.com/apache/ozone/pull/6044#issuecomment-1903577742). These were not caught because backwards compatibility check was still comparing to Ozone 1.3.0's proto definition. But HDDS-9426 is not present in 1.4.0, it was implemented during the release process. So we need it to be compatible with 1.4.0 proto definitions. https://issues.apache.org/jira/browse/HDDS-9426 ## How was this patch tested? Verified backwards compatibility check does not report any errors with `proto.lock` changes from #6044 after this revert. ``` $ mvn -DskipTests clean verify ... [INFO] --- proto-backwards-compatibility:1.0.7:backwards-compatibility-check (default) @ ozone-interface-client --- [INFO] protolock cmd line: hadoop-ozone/interface-client/target/protolock-bin/protolock status --lockdir=hadoop-ozone/interface-client/target/classes --protoroot=hadoop-ozone/interface-client/target/classes [INFO] protolock cmd line: hadoop-ozone/interface-client/target/protolock-bin/protolock commit --lockdir=hadoop-ozone/interface-client/target/classes --protoroot=hadoop-ozone/interface-client/target/classes [INFO] Backwards compatibility check passed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
