smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461863286
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string,
object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
Review Comment:
@ArafatKhan2198
There is slight difference between undefined and ! operator
For Example
function test(t) {
if (!t) {
return 'Undefined value!';
}
return t;
}
let x=0;
console.log(test(x));
Output:- Undefined value!
For this scenario ! operator is not properly checking our conditions. We
have to check empty or undefined values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
