swamirishi commented on code in PR #6057:
URL: https://github.com/apache/ozone/pull/6057#discussion_r1462083724
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/util/OMMultipartUploadUtils.java:
##########
@@ -93,8 +91,7 @@ public static String getMultipartOpenKey(String volumeName,
OMMetadataManager omMetadataManager, BucketLayout bucketLayout)
throws IOException {
if (bucketLayout == BucketLayout.FILE_SYSTEM_OPTIMIZED) {
- return getMultipartOpenKeyFSO(volumeName, bucketName,
- keyName, multipartUploadId, omMetadataManager);
+ return omMetadataManager.getMultipartKeyFSO(volumeName, bucketName,
keyName, multipartUploadId);
} else {
return getMultipartOpenKey(volumeName, bucketName,
Review Comment:
I believe we can remove this method as well since there no other usages for
the method.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/util/OMMultipartUploadUtils.java:
##########
@@ -93,8 +91,7 @@ public static String getMultipartOpenKey(String volumeName,
OMMetadataManager omMetadataManager, BucketLayout bucketLayout)
throws IOException {
if (bucketLayout == BucketLayout.FILE_SYSTEM_OPTIMIZED) {
- return getMultipartOpenKeyFSO(volumeName, bucketName,
- keyName, multipartUploadId, omMetadataManager);
+ return omMetadataManager.getMultipartKeyFSO(volumeName, bucketName,
keyName, multipartUploadId);
} else {
return getMultipartOpenKey(volumeName, bucketName,
Review Comment:
```suggestion
return omMetadataManager.getMultipartKey(volumeName, bucketName,
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -836,7 +835,7 @@ public OmMultipartUploadListParts listParts(String
volumeName,
//if there are no parts, use the replicationType from the open key.
if (isBucketFSOptimized(volumeName, bucketName)) {
multipartKey =
- getMultipartOpenKeyFSO(volumeName, bucketName, keyName,
+ metadataManager.getMultipartKeyFSO(volumeName, bucketName,
keyName,
Review Comment:
I believe we should use the OMMultipartUploadUtils.getMultipartOpenKey()
function here, since we want to look into the open key table and not the main
table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
