jojochuang commented on code in PR #6054:
URL: https://github.com/apache/ozone/pull/6054#discussion_r1462519556


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
@@ -279,18 +249,69 @@ public void testOverwriteHSyncFile() throws Exception {
     }
   }
 
-  static void runTestHSync(FileSystem fs, Path file, int initialDataSize)

Review Comment:
   The runTestHSync() used by testO3fsHSync() and testOfsHSync() are meant to 
verify the behavior of concurrent write and read of the same file. It's also 
the behavior required by HBase.
   
   IMO we should modify runTestHSync() but we should need to verify this 
behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to