GeorgeJahad opened a new pull request, #6069:
URL: https://github.com/apache/ozone/pull/6069

   ## What changes were proposed in this pull request?
   
   Modify TestOMRatisSnapshots.testInstallSnapshot() to ignore sst files that 
are not live.
   
   The test is flakey because it ignores the fact that some of the rocksdb sst 
files are not "live".
   
   ### What is a "live" file?
   After a compaction, a compacted file may not be immediately deleted if it is 
still in use.  In those cases, the file is no longer considered "live" and no 
hard link is created for it during a rocksdb checkpoint operation.  But the 
file still exists on the filesystem and testInstallSnapshot was incorrectly 
considering them.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-10059
   
   
   ## How was this patch tested?
   
   Ran it 400 times here: 
https://github.com/GeorgeJahad/ozone/actions/runs/7619254060
   
   Still fails 1% of the time, but without the fix it was around 50%.  I think 
there maybe another problem, but this is an important test that needs to be 
re-enabled now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to