[
https://issues.apache.org/jira/browse/HDDS-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Andika updated HDDS-10181:
-------------------------------
Description:
It's observed that the serialization (toProtobuf) and deserialization
(fromProtobuf) of OmPrefixInfo uses OzoneAclStorageUtil, whereas OmKeyInfo,
OmBucketInfo, OmVolumeArgs uses OzoneAclUtil. The logic for both classes looks
the same.
There are also duplicate proto definitions for OzoneAclInfo in
OmStorageProtocol.proto and OmClientProtocol.proto.
We need to remove the duplication to prevent any divergence.
Note: This seems the separation was done as part of HDDS-4242, under HDDS-4216
which are supposed to separate RPC and storage proto files for compatibility
reasons by introducing interface-storage package. But it seems only PrefixInfo
and UserVolumeInfo have been done for this. If these changes are intended, this
can be closed and we can focus on separating the remaining protos instead.
was:
It's observed that the serialization (toProtobuf) and deserialization
(fromProtobuf) of OmPrefixInfo uses OzoneAclStorageUtil, whereas OmKeyInfo,
OmBucketInfo, OmVolumeArgs uses OzoneAclUtil. The logic for both classes looks
the same.
There are also duplicate proto definitions for OzoneAclInfo in
OmStorageProtocol.proto and OmClientProtocol.proto.
We need to remove the duplication to prevent any divergence.
> Remove duplicate ACL protobuf definitions in interface-storage
> --------------------------------------------------------------
>
> Key: HDDS-10181
> URL: https://issues.apache.org/jira/browse/HDDS-10181
> Project: Apache Ozone
> Issue Type: Improvement
> Components: OM
> Affects Versions: 1.4.0
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> It's observed that the serialization (toProtobuf) and deserialization
> (fromProtobuf) of OmPrefixInfo uses OzoneAclStorageUtil, whereas OmKeyInfo,
> OmBucketInfo, OmVolumeArgs uses OzoneAclUtil. The logic for both classes
> looks the same.
> There are also duplicate proto definitions for OzoneAclInfo in
> OmStorageProtocol.proto and OmClientProtocol.proto.
> We need to remove the duplication to prevent any divergence.
> Note: This seems the separation was done as part of HDDS-4242, under
> HDDS-4216 which are supposed to separate RPC and storage proto files for
> compatibility reasons by introducing interface-storage package. But it seems
> only PrefixInfo and UserVolumeInfo have been done for this. If these changes
> are intended, this can be closed and we can focus on separating the remaining
> protos instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
