siddhantsangwan commented on code in PR #5929:
URL: https://github.com/apache/ozone/pull/5929#discussion_r1462805287
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -588,6 +589,16 @@ public void deleteContainer(long containerID) throws
IOException {
}
}
+ @Override
+ public Map<String, List<ContainerID>>
getContainersOnDecomNode(DatanodeDetails dn) throws IOException {
+ try {
+ return scm.getScmDecommissionManager().getContainersReplicatedOnNode(
+ new DatanodeAdminMonitorImpl.TrackedNode(dn, 0L));
Review Comment:
What do you think about changing this method's definition in
`NodeDecommissionManager` to accept `DatanodeDetails` instead of `TrackedNode`?
That way `SCMClientProtocolServer` or other users don't need to know about
`TrackedNode` at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
