dombizita commented on code in PR #5658:
URL: https://github.com/apache/ozone/pull/5658#discussion_r1463238883
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -1045,10 +1077,11 @@ export class Om extends React.Component<Record<string,
object>, IOmdbInsightsSta
const paginationConfig: PaginationConfig = {
pageSize:this.state.DEFAULT_LIMIT,
defaultPageSize: this.state.DEFAULT_LIMIT,
- pageSizeOptions: ['10', '20', '30', '50'],
- showSizeChanger: true,
+ pageSizeOptions: ['10', '30', '50', '100'],
+ showSizeChanger: this.state.nextClickable ? true : false,
onShowSizeChange: this.onShowSizeChange,
- itemRender: this.itemRender
+ itemRender: this.itemRender,
+ total: this.state.pageDisplayCount - 1
Review Comment:
What is `total` here?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -491,9 +502,8 @@ export class Om extends React.Component<Record<string,
object>, IOmdbInsightsSta
cancelMismatchedEndpointSignal = controller;
request.then(mismatchContainersResponse => {
const mismatchContainers: IContainerResponse[] =
mismatchContainersResponse && mismatchContainersResponse.data &&
mismatchContainersResponse.data.containerDiscrepancyInfo;
- if (mismatchContainersResponse && mismatchContainersResponse.data &&
mismatchContainersResponse.data.lastKey === null) {
+ if (mismatchContainers && mismatchContainers.length === 0) {
//No Further Records may be last record
- mismatchPrevKeyList = [0];
Review Comment:
Shouldn't we do a `prevKeyListMap.clear();` here?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -31,11 +31,10 @@ import { AxiosGetHelper, cancelRequests } from
'utils/axiosRequestHelper';
const size = filesize.partial({ standard: 'iec' });
const { TabPane } = Tabs;
//Previous Key Need to store respective Lastkey of each API
Review Comment:
I think this comment became unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
