szetszwo commented on code in PR #6049:
URL: https://github.com/apache/ozone/pull/6049#discussion_r1463617825
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java:
##########
@@ -218,6 +225,15 @@ public static final class ReplicationConfig {
)
private double outOfServiceFactor = OUTOFSERVICE_FACTOR_DEFAULT;
+ @Config(key = ZEROCOPY_ENABLE_KEY,
+ type = ConfigType.BOOLEAN,
+ defaultValue = ZEROCOPY_ENABLE_DEFAULT_VALUE,
+ tags = {DATANODE, SCM},
+ description = "Specify if zero-copy should be enabled for " +
+ "replication protocol."
+ )
+ private boolean zeroCopyEnable = ZEROCOPY_ENABLE_DEFAULT;
+
Review Comment:
@guohao-rosicky , thanks a lot for working this!
Why would anyone want to disable it? Let's don't add this conf and enable
it always?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
