adoroszlai commented on PR #6055:
URL: https://github.com/apache/ozone/pull/6055#issuecomment-1907435822

   I tested this for a short period, RocksDB statistics looked OK in Prometheus.
   
   ```
   cd hadoop-ozone/dist/target/ozone-1.5.0-SNAPSHOT/compose/ozone
   export COMPOSE_FILE=docker-compose.yaml:monitoring.yaml
   OZONE_DATANODES=3 ./run.sh -d
   docker-compose exec -T scm ozone freon ockg -n10000 -t4
   open http://localhost:9090
   ```
   
   Still, closing `Statistics` doesn't seem right.  I think it should be kept 
in `RDBStore` (passed via `DBStoreBuilder`), and closed in `RDBStore#close`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to