sumitagrawl commented on code in PR #6050:
URL: https://github.com/apache/ozone/pull/6050#discussion_r1464355204
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -708,9 +706,22 @@ private ContainerMoveSelection
matchSourceWithTarget(DatanodeDetails source) {
LOG.debug("ContainerBalancer is finding suitable target for source " +
"datanode {}", source.getUuidString());
}
- ContainerMoveSelection moveSelection =
- findTargetStrategy.findTargetForContainerMove(
- source, candidateContainers);
+
+ ContainerMoveSelection moveSelection = null;
+ Set<ContainerID> toRemoveContainerIds = new HashSet<>();
+ for (ContainerID containerId: sourceContainerIDSet) {
+ if (selectionCriteria.shouldBeExcluded(containerId, source,
+ sizeScheduledForMoveInLatestIteration)) {
+ toRemoveContainerIds.add(containerId);
+ continue;
+ }
+ moveSelection = findTargetStrategy.findTargetForContainerMove(source,
+ containerId);
+ if (moveSelection != null) {
+ break;
+ }
+ }
+ sourceContainerIDSet.removeAll(toRemoveContainerIds);
Review Comment:
this will implicitly remove from CBSelectionCriteria->setMap, as referring
same list. we can have a comment over this like specifying same for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
