xBis7 commented on PR #5651:
URL: https://github.com/apache/ozone/pull/5651#issuecomment-1908446893

   @sumitagrawl Healthy has a different meaning for the ReplicationManager and 
for Recon and so it's tricky to define it. For RM, an over-replicated container 
isn't unhealthy. But Recon defines all states where we don't have the correct 
number of replicas as unhealthy, so that the containers can appear in the 
container-endpoint.
   
   If I understand correctly, you are suggesting to change this 
   ```java
     public boolean isProperlyReplicated() {
       return replicaDelta == 0 && !isMisReplicated();
     }
   ```
   to this
   ```java
     public boolean isProperlyReplicated() {
       return replicaDelta >= 0 && !isMisReplicated();
     }
   ```
   Is that correct?
   
   So that we can say that a container is properly replicated if it's neither 
under-replicated nor mis-replicated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to