aierate commented on PR #6070:
URL: https://github.com/apache/ozone/pull/6070#issuecomment-1909342492
> > @tanvipenumudy Thanks for you Patch.
> > You need to have `XceiverClientMetrics` implement `MetricsSource` and
override `getMetrics`. just like:
> > ```java
> > public final class XceiverClientMetrics implements MetricsSource {
> > @Override
> > public void (MetricsCollector collector, boolean all) {
> > //....
> > }
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > This is because Hadoop Metrics only supports the automatic retrieval of
values from Hadoop's built-in classes. `MutableMinMax` is a custom class, so if
`getMetrics` is not overridden, then `MutableMinMax` will not be updated. You
can test that the `Min/Max` metric will always be 0 in the current
implementation.
>
> @xichen01 Thanks for your suggestion very much. I am fixed this bug,
please take a look.
Here is the jmx after fixed this bug.
http://ozone:9878/jmx?qry=Hadoop:service=S3Gateway,name=XceiverClientMetrics
```
{
"name" : "Hadoop:service=S3Gateway,name=XceiverClientMetrics",
"modelerType" : "XceiverClientMetrics",
"tag.Context" : "dfs",
"tag.Hostname" : "conway-hadoop3",
"PendingOps" : 0,
"TotalOps" : 4,
"EcReconstructionTotal" : 0,
"EcReconstructionFailsTotal" : 0,
"numPendingCreateContainer" : 0,
"opCountCreateContainer" : 0,
"CreateContainerLatencyNumOps" : 0,
"CreateContainerLatencyAvgTime" : 0.0,
"CreateContainerLatency60sNumOps" : 0,
"CreateContainerLatency60s50thPercentileTime" : 0,
"CreateContainerLatency60s75thPercentileTime" : 0,
"CreateContainerLatency60s90thPercentileTime" : 0,
"CreateContainerLatency60s95thPercentileTime" : 0,
"CreateContainerLatency60s99thPercentileTime" : 0,
"CreateContainerLatency300sNumOps" : 0,
"CreateContainerLatency300s50thPercentileTime" : 0,
"CreateContainerLatency300s75thPercentileTime" : 0,
"CreateContainerLatency300s90thPercentileTime" : 0,
"CreateContainerLatency300s95thPercentileTime" : 0,
"CreateContainerLatency300s99thPercentileTime" : 0,
"CreateContainerLatencyIMinTime" : 3.4028234663852886E38,
"CreateContainerLatencyIMaxTime" : 1.401298464324817E-45,
.
.
.
"numPendingPutBlock" : 0,
"opCountPutBlock" : 2,
"PutBlockLatencyNumOps" : 2,
"PutBlockLatencyAvgTime" : 30.0,
"PutBlockLatency60sNumOps" : 1,
"PutBlockLatency60s50thPercentileTime" : 30,
"PutBlockLatency60s75thPercentileTime" : 30,
"PutBlockLatency60s90thPercentileTime" : 30,
"PutBlockLatency60s95thPercentileTime" : 30,
"PutBlockLatency60s99thPercentileTime" : 30,
"PutBlockLatency300sNumOps" : 0,
"PutBlockLatency300s50thPercentileTime" : 0,
"PutBlockLatency300s75thPercentileTime" : 0,
"PutBlockLatency300s90thPercentileTime" : 0,
"PutBlockLatency300s95thPercentileTime" : 0,
"PutBlockLatency300s99thPercentileTime" : 0,
"PutBlockLatencyIMinTime" : 30.0,
"PutBlockLatencyIMaxTime" : 30.0,
.
.
.
"numPendingStreamWrite" : 0,
"opCountStreamWrite" : 0,
"StreamWriteLatencyNumOps" : 0,
"StreamWriteLatencyAvgTime" : 0.0,
"StreamWriteLatency60sNumOps" : 0,
"StreamWriteLatency60s50thPercentileTime" : 0,
"StreamWriteLatency60s75thPercentileTime" : 0,
"StreamWriteLatency60s90thPercentileTime" : 0,
"StreamWriteLatency60s95thPercentileTime" : 0,
"StreamWriteLatency60s99thPercentileTime" : 0,
"StreamWriteLatency300sNumOps" : 0,
"StreamWriteLatency300s50thPercentileTime" : 0,
"StreamWriteLatency300s75thPercentileTime" : 0,
"StreamWriteLatency300s90thPercentileTime" : 0,
"StreamWriteLatency300s95thPercentileTime" : 0,
"StreamWriteLatency300s99thPercentileTime" : 0,
"StreamWriteLatencyIMinTime" : 3.4028234663852886E38,
"StreamWriteLatencyIMaxTime" : 1.401298464324817E-45
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
