Tejaskriya commented on code in PR #5941:
URL: https://github.com/apache/ozone/pull/5941#discussion_r1465878653
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/helpers/OmPrefixInfo.java:
##########
@@ -200,12 +210,25 @@ public boolean equals(Object o) {
OmPrefixInfo that = (OmPrefixInfo) o;
return name.equals(that.name) &&
Objects.equals(acls, that.acls) &&
- Objects.equals(metadata, that.metadata);
+ Objects.equals(metadata, that.metadata) &&
+ objectID == that.objectID &&
+ updateID == that.updateID;
}
@Override
public int hashCode() {
- return Objects.hash(name);
+ return Objects.hash(name, acls, metadata, objectID, updateID);
+ }
+
+ @Override
+ public String toString() {
+ return "OmPrefixInfo{" +
+ "name='" + name + '\'' +
+ ", acls=" + acls +
+ ", metadata=" + metadata +
+ ", objectID=" + objectID +
+ ", updateID=" + updateID +
+ '}';
Review Comment:
As the line length has been increased to 120, we could reduce the no. of
lines used in this return statement. Although a new commit needn't be pushed
just for this, if there are other changes being made later this can be included
in that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
