sodonnel commented on code in PR #6090:
URL: https://github.com/apache/ozone/pull/6090#discussion_r1466223025
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/AbstractFindTargetGreedy.java:
##########
@@ -228,6 +228,9 @@ public void increaseSizeEntering(DatanodeDetails target,
long size) {
if (totalEnteringSize < config.getMaxSizeEnteringTarget()) {
//reorder
potentialTargets.add(nodeManager.getUsageInfo(target));
+ } else {
+ logger.debug("Datanode {} removed from the list of potential targets.
The total size of data entering it in " +
Review Comment:
There is no need to wrap it in an IF statement unless there is expensive
logic to form the message. Inside the logger it has the isDebugEnabled check
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
