ChenSammi commented on code in PR #5663: URL: https://github.com/apache/ozone/pull/5663#discussion_r1467425435
########## hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/TestBlockOutputStreamIncrementalPutBlock.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.client; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import java.util.HashMap; +import java.util.UUID; + +import org.apache.hadoop.ozone.om.helpers.ServiceInfoEx; +import org.jetbrains.annotations.NotNull; + +import org.apache.commons.lang3.RandomStringUtils; +import org.apache.hadoop.hdds.client.ReplicationConfig; +import org.apache.hadoop.hdds.conf.ConfigurationSource; +import org.apache.hadoop.hdds.conf.InMemoryConfiguration; +import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos; +import org.apache.hadoop.hdds.scm.OzoneClientConfig; +import org.apache.hadoop.hdds.scm.XceiverClientFactory; +import org.apache.hadoop.ozone.client.io.OzoneInputStream; +import org.apache.hadoop.ozone.client.io.OzoneOutputStream; +import org.apache.hadoop.ozone.client.rpc.RpcClient; +import org.apache.hadoop.ozone.om.protocolPB.OmTransport; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; + +import static org.junit.jupiter.api.Assertions.assertArrayEquals; + + +/** + * Verify BlockOutputStream with incremental PutBlock feature. + * (ozone.client.incremental.chunk.list = true) + */ +public class TestBlockOutputStreamIncrementalPutBlock { + private OzoneClient client; + private final String keyName = UUID.randomUUID().toString(); + private final String volumeName = UUID.randomUUID().toString(); + private final String bucketName = UUID.randomUUID().toString(); + private OzoneBucket bucket; + private final ConfigurationSource config = new InMemoryConfiguration(); + + public static Iterable<Boolean> parameters() { + return Arrays.asList(true, false); + } + + public void init(boolean incrementalChunkList) throws IOException { + OzoneClientConfig clientConfig = config.getObject(OzoneClientConfig.class); + + clientConfig.setIncrementalChunkList(incrementalChunkList); + clientConfig.setChecksumType(ContainerProtos.ChecksumType.CRC32C); + + ((InMemoryConfiguration)config).setFromObject(clientConfig); + + RpcClient rpcClient = new RpcClient(config, null) { + + @Override + protected OmTransport createOmTransport( + String omServiceId) + throws IOException { + return new MockOmTransport(); + } + + @NotNull + @Override + protected XceiverClientFactory createXceiverClientFactory( + ServiceInfoEx serviceInfo) throws IOException { + return new MockXceiverClientFactory(); + } + }; + + client = new OzoneClient(config, rpcClient); + ObjectStore store = client.getObjectStore(); + + store.createVolume(volumeName); + OzoneVolume volume = store.getVolume(volumeName); + volume.createBucket(bucketName); + bucket = volume.getBucket(bucketName); + } + + @AfterEach + public void close() throws IOException { + client.close(); + } + + @ParameterizedTest + @MethodSource("parameters") + public void writeSmallKey(boolean incrementalChunkList) + throws IOException { + init(incrementalChunkList); + + int size = 1024; + String s = RandomStringUtils.randomAlphabetic(1024); + ByteBuffer byteBuffer = ByteBuffer.wrap(s.getBytes(StandardCharsets.UTF_8)); + + try (OzoneOutputStream out = bucket.createKey(keyName, size, + ReplicationConfig.getDefault(config), new HashMap<>())) { + for (int i = 0; i < 4097; i++) { + out.write(byteBuffer); + out.hsync(); + } + } + + try (OzoneInputStream is = bucket.readKey(keyName)) { + ByteBuffer readBuffer = ByteBuffer.allocate(size); + for (int i = 0; i < 4097; i++) { + is.read(readBuffer); + assertArrayEquals(readBuffer.array(), byteBuffer.array()); + } + } + } + + @ParameterizedTest + @MethodSource("parameters") + public void writeLargeKey(boolean incrementalChunkList) + throws IOException { + init(incrementalChunkList); + + int size = 1024 * 1024 + 1; + ByteBuffer byteBuffer = ByteBuffer.allocate(size); + + try (OzoneOutputStream out = bucket.createKey(keyName, size, + ReplicationConfig.getDefault(config), new HashMap<>())) { + for (int i = 0; i < 4; i++) { + out.write(byteBuffer); + out.hsync(); + } + } + + try (OzoneInputStream is = bucket.readKey(keyName)) { + ByteBuffer readBuffer = ByteBuffer.allocate(size); + for (int i = 0; i < 4; i++) { + is.read(readBuffer); Review Comment: I added one check here, it failed ` int readLen = is.read(readBuffer); assertEquals(bufferSize, readLen); ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
