xichen01 commented on code in PR #5791:
URL: https://github.com/apache/ozone/pull/5791#discussion_r1469914548
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2358,7 +2366,7 @@ private KeyOutputStream.Builder createKeyOutputStream(
.enableUnsafeByteBufferConversion(unsafeByteBufferConversion)
.setConfig(clientConfig)
.setAtomicKeyCreation(isS3GRequest.get())
- .setClientMetrics(clientMetrics)
+
.setBlockOutPutStreamResourceProvider(blockOutPutStreamResourceProvider)
Review Comment:
> Maybe I'm missing something, but it seems the same `ecWriteExecutor` is
used for both EC and Ratis keys:
>
>
https://github.com/apache/ozone/blob/f695a374420a49728e2be352534cbdbe48ece0d9/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java#L319-L320
>
> @xichen01 Shouldn't we use a different resource provider for Ratis keys?
@adoroszlai Yes, since Ratis Key and EC Key reuse class `BlockOutputStream`,
the EC Key and Ratis Key both use this `ecWriteExecutor`. I think that's
acceptable, since `ecWriteExecutor` just provides thread resources, not logic.
And the Ratis key also benefits from not having to create a new thread for each
Block. But mybe we need rename the `ecWriteExecutor` to a more normal name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
