will-sh commented on PR #65: URL: https://github.com/apache/ozone-site/pull/65#issuecomment-1916010914
Thanks @errose28 for the review. > Added responsive design for mobile devices. > Can you elaborate more on this point? In the banner.css file, we've implemented a responsive layout that adjusts to different screen sizes. For larger screens like desktops or laptops, we use a flex layout, as detailed in this [guide to flexbox](https://css-tricks.com/snippets/css/a-guide-to-flexbox/). For smaller screens, such as those on mobile devices, we've added CSS [media queries](https://www.w3schools.com/css/css_rwd_mediaqueries.asp) to ensure the components adapt to the screen size. This approach allows the page layout to respond dynamically to various device sizes, enhancing usability across devices. > Where did the banner image come from? Are there any licensing implications we should know about? Do we have the ability to adjust it in any way (change some colors in the image, for example)? The banner image, banner.png, was created from scratch using Figma, a popular design tool known for its versatility and ease of use. As the image is an original design and not derived from existing internet resources, there are no licensing issues. We used the **Helvetica** font, which is a standard option in Figma’s font library. The advantage of designing in Figma or Adobe Illustrator is not only creative freedom but also the avoidance of licensing complications often associated with using pre-existing images. Also, another advantage of using Figma is easy to adjust the PNG size according to different screen sizes. Feedback and suggestions are welcome regarding the banner style. If anyone has thoughts on its design or ideas for improvement, I'd greatly appreciate the input. We can discuss potential changes to ensure the banner effectively aligns with our project's aesthetic and functional goals. > Is ozone-logo-hug.svg just a cropped version of ozone-logo.svg? I'd been meaning to crop that svg image down to a proper size, so if this is the case I think we can just make this tighter cropped version the new ozone-logo.svg. Yes, ozone-logo-hug.svg is a cropped version of ozone-logo.svg, tailored using Figma to achieve a more appropriate and tight size. This adjustment makes it easier to align with other components in the layout. I agree with your suggestion to adopt this tighter-cropped version as the new ozone-logo.svg. This change should streamline our asset library and ensure consistency in our visual presentations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
