ChenSammi commented on code in PR #5391:
URL: https://github.com/apache/ozone/pull/5391#discussion_r1471268245
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeSchemaManager.java:
##########
@@ -76,6 +76,21 @@ public void init(ConfigurationSource conf) {
}
}
+ public void init(String schemaFile) {
Review Comment:
Could you refactor the init(ConfigurationSource conf) so that the two init
will share the most common load logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
