Galsza opened a new pull request, #6184:
URL: https://github.com/apache/ozone/pull/6184

   ## What changes were proposed in this pull request?
   
   In OMRequestTestUtils the createOmKeyInfo was repeated a lot of times with 
minor changes instead of using a builder pattern. Here those usages are 
eliminated and only 2 of them remains.
   
   The two methods only differ in 1 parameter because the setter 
`setOmKeyLocationInfos` is actually an addAll method that doesn't overwrite the 
previous values and there could be unforeseen bugs storing multiple 
OmKeyLocationInfos with the same version number.
   
   Another small refactor is that instead of using replication type and factor 
together they are combined into replicationconfig now.
   
   [HDDS-10266](https://issues.apache.org/jira/browse/HDDS-10226)
   
   ## How was this patch tested?
   
   No functional change was created for production code, all tests have passed 
in ci run:
   https://github.com/Galsza/ozone/actions/runs/7800629334/job/21280738076
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to