smengcl commented on code in PR #6014:
URL: https://github.com/apache/ozone/pull/6014#discussion_r1481993266
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/CommitWatcher.java:
##########
@@ -52,7 +53,7 @@ class CommitWatcher extends
AbstractCommitWatcher<ChunkBuffer> {
}
@Override
- XceiverClientReply watchForCommit(long commitIndex) {
+ XceiverClientReply watchForCommit(long commitIndex) throws IOException {
Review Comment:
Note to self: I chose to keep the `throws IOException` in the signature
here. The other choice is to remove the big `catch` clause in
`TestCommitWatcher`, which might still be useful at some point so I kept it
(maybe can remove later).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
