hemantk-12 commented on code in PR #6186:
URL: https://github.com/apache/ozone/pull/6186#discussion_r1482291660
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestSCMRestart.java:
##########
@@ -60,17 +61,17 @@ public class TestSCMRestart {
*/
@BeforeAll
public static void init() throws Exception {
+ final int numOfNodes = 4;
conf = new OzoneConfiguration();
conf.setTimeDuration(HDDS_PIPELINE_REPORT_INTERVAL, 1000,
TimeUnit.MILLISECONDS);
+ conf.setTimeDuration(HDDS_HEARTBEAT_INTERVAL, 1000, TimeUnit.MILLISECONDS);
+ conf.setTimeDuration(ScmConfigKeys.OZONE_SCM_HEARTBEAT_PROCESS_INTERVAL,
1000, TimeUnit.MILLISECONDS);
conf.setInt(ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT, 1);
- int numOfNodes = 4;
+ // allow only one FACTOR THREE pipeline.
Review Comment:
nit: not related to this PR, but this comment doesn't make sense to me.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/dn/ratis/TestDnRatisLogParser.java:
##########
@@ -50,8 +51,9 @@ public class TestDnRatisLogParser {
@BeforeEach
public void setup() throws Exception {
OzoneConfiguration conf = new OzoneConfiguration();
+ conf.setInt(OZONE_SCM_RATIS_PIPELINE_LIMIT, 2);
Review Comment:
I don't think this line is needed and default value, from `ozone-site.xml`,
should be used.
If I'm not wrong, default value 3 was used when `totalPipelineNumLimit` was
set less than 3 previously.
https://github.com/apache/ozone/blob/68c6f71b2d37bcee40957a8faa9083c9c9ef044f/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java#L711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
