Cyrill commented on code in PR #6135:
URL: https://github.com/apache/ozone/pull/6135#discussion_r1482594020
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/ReferenceCounted.java:
##########
@@ -48,13 +48,7 @@ public class ReferenceCounted<T, U>
*/
private final Object refCountLock = new Object();
- /**
- * Parent instance whose callback will be triggered upon this RC closure.
- */
- private final U parentWithCallback;
Review Comment:
I'm fine with leaving the unused field, though I strongly believe the
callback should not be a part of the class generics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
