sadanand48 commented on code in PR #6195:
URL: https://github.com/apache/ozone/pull/6195#discussion_r1483888672
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -609,16 +609,20 @@ public ListKeysResult listKeys(String volumeName, String
bucketName,
int maxKeys) throws IOException {
Preconditions.checkNotNull(volumeName);
Preconditions.checkNotNull(bucketName);
-
+ OmBucketInfo omBucketInfo = metadataManager.validateBucket(volumeName,
bucketName);
Review Comment:
There is already a method KeyManagerImpl#getBucketInfo which does this, We
can check null after getting the bucketInfo instead of adding a new method and
implementation. Also I think we can only do this once instead of checking again
in metadataManager#listKeys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
