[ 
https://issues.apache.org/jira/browse/HDDS-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Doroszlai updated HDDS-10331:
------------------------------------
    Description: 
HDDS-815 renames config keys prefixed with {{dfs.}}, which was inherited from 
Ozone's Hadoop backgrounds.  The goal of this task is to rename the 
corresponding Java constants, both for config key and for default value.

Example:

{code:title=https://github.com/apache/ozone/blob/c1efa330d338d586cbe3a10886f9ce936b5b77df/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java#L44-L47}
  public static final String DFS_CONTAINER_RATIS_ENABLED_KEY
      = "dfs.container.ratis.enabled";
  public static final boolean DFS_CONTAINER_RATIS_ENABLED_DEFAULT
      = false;
{code}

HDDS-815 changes {{dfs.container.ratis.enabled}} to 
{{hdds.container.ratis.enabled}}.  As part of this task we should rename:
 * {{DFS_CONTAINER_RATIS_ENABLED_KEY}} to {{HDDS_CONTAINER_RATIS_ENABLED_KEY}}
 * {{DFS_CONTAINER_RATIS_ENABLED_DEFAULT}} to 
{{HDDS_CONTAINER_RATIS_ENABLED_DEFAULT}}

This change is extracted to a separate sub-task because it will affect much 
more files, but is a simple refactoring, does not affect users or compatibility.

  was:
{{hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
54:      = "dfs.container.ratis.num.write.chunk.threads.per.volume";
82:      "dfs.container.ratis.statemachinedata.sync.retries";
85:      "dfs.container.ratis.statemachine.max.pending.apply-transactions";
92:      "dfs.container.ratis.log.queue.num-elements";
96:      "dfs.container.ratis.log.queue.byte-limit";
101:      "dfs.container.ratis.log.appender.queue.num-elements";
105:      "dfs.container.ratis.log.appender.queue.byte-limit";
109:      "dfs.container.ratis.log.purge.gap";
114:      "dfs.container.ratis.leader.pending.bytes.limit";
119:      "dfs.ratis.server.retry-cache.timeout.duration";

hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java
68:      "dfs.container.ratis.datastream.random.port";
74:      "dfs.container.chunk.write.sync";
86:      "dfs.container.ratis.admin.port";
92:      "dfs.container.ratis.server.port";
99:      = "dfs.container.ratis.datastream.enabled";
103:      = "dfs.container.ratis.datastream.port";}}

{{Also, Java constants for default values of the renamed config keys still use 
the old }}{{DFS_}}{{ prefix.}}


> Rename Java constants of the config keys
> ----------------------------------------
>
>                 Key: HDDS-10331
>                 URL: https://issues.apache.org/jira/browse/HDDS-10331
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Sarveksha Yeshavantha Raju
>            Assignee: Sarveksha Yeshavantha Raju
>            Priority: Major
>
> HDDS-815 renames config keys prefixed with {{dfs.}}, which was inherited from 
> Ozone's Hadoop backgrounds.  The goal of this task is to rename the 
> corresponding Java constants, both for config key and for default value.
> Example:
> {code:title=https://github.com/apache/ozone/blob/c1efa330d338d586cbe3a10886f9ce936b5b77df/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java#L44-L47}
>   public static final String DFS_CONTAINER_RATIS_ENABLED_KEY
>       = "dfs.container.ratis.enabled";
>   public static final boolean DFS_CONTAINER_RATIS_ENABLED_DEFAULT
>       = false;
> {code}
> HDDS-815 changes {{dfs.container.ratis.enabled}} to 
> {{hdds.container.ratis.enabled}}.  As part of this task we should rename:
>  * {{DFS_CONTAINER_RATIS_ENABLED_KEY}} to {{HDDS_CONTAINER_RATIS_ENABLED_KEY}}
>  * {{DFS_CONTAINER_RATIS_ENABLED_DEFAULT}} to 
> {{HDDS_CONTAINER_RATIS_ENABLED_DEFAULT}}
> This change is extracted to a separate sub-task because it will affect much 
> more files, but is a simple refactoring, does not affect users or 
> compatibility.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to