adoroszlai commented on code in PR #6205:
URL: https://github.com/apache/ozone/pull/6205#discussion_r1485101910
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.java:
##########
@@ -97,9 +97,23 @@ public OzoneAcl(ACLIdentityType type, String name, ACLType
acl,
*
* @param type - Type
* @param name - Name of user
- * @param acls - Rights
* @param scope - AclScope
+ * @param acls - Rights
*/
+ public OzoneAcl(ACLIdentityType type, String name, AclScope scope,
ACLType... acls) {
+ this(type, name, bitSetOf(acls), scope);
+ }
+
+ private static BitSet bitSetOf(ACLType... acls) {
+ BitSet bits = new BitSet();
+ if (acls != null && acls.length > 0) {
Review Comment:
What's the problem with `acls.length > 0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]