adoroszlai commented on code in PR #75:
URL: https://github.com/apache/ozone-site/pull/75#discussion_r1489240858
##########
.github/workflows/pull-request.yml:
##########
@@ -16,22 +16,31 @@
name: pull request
on:
- pull_request:
+ pull_request_target:
types:
- - reopened
- - opened
- - edited
- - synchronize
+ - reopened
+ - opened
+ - edited
+ - synchronize
+ - pull_request_target
jobs:
title:
runs-on: ubuntu-latest
steps:
- - name: Checkout project
- uses: actions/checkout@v4
- - name: Check pull request title
- env:
- TITLE: ${{ github.event.pull_request.title }}
- run:
- .github/scripts/pr_title_check.sh "${TITLE}"
-
+ - name: Checkout project
+ uses: actions/checkout@v4
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ .github/scripts/pr_title_check.sh "${TITLE}"
Review Comment:
GitHub Actions doc
[says](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target)
about `pull_request_target`:
> Avoid using this event if you need to build or run code from the pull
request.
Thus, I think we should keep these checks separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
