duongkame commented on code in PR #6219:
URL: https://github.com/apache/ozone/pull/6219#discussion_r1490244995
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java:
##########
@@ -154,10 +155,10 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
.map(info -> info.getProtobuf(getOmRequest().getVersion()))
.collect(Collectors.toList()));
+ generateRequiredEncryptionInfo(keyArgs, newKeyArgs, ozoneManager);
Review Comment:
This method's name and what it does is not consistent. I'd suggest to rename
it as `setEncryptionInfo` or change it in a way that it returns a
`FileEncryptionInfoProto` that is explicitly set by the client code:
```
newKeyArgs.setFileEncryptionInfo(generateEncryptionInfo(keyArgs,
ozoneManager);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
