[ 
https://issues.apache.org/jira/browse/HDDS-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817627#comment-17817627
 ] 

Sumit Agrawal commented on HDDS-10385:
--------------------------------------

[~Symious] 

This memory will be occupied by every ThreadLocal instance is 32 byte, so grow 
of memory will not be observed in small run.

But with heap dump and analysis of increase in object OMLockDetails can be 
observed.

 

Last example in below link will give idea about this and last example in this 
shows about instance level variable ...

https://stackoverflow.com/questions/17968803/threadlocal-memory-leak

> Memory leak for thread local usages in OMClientRequest
> ------------------------------------------------------
>
>                 Key: HDDS-10385
>                 URL: https://issues.apache.org/jira/browse/HDDS-10385
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: Ozone Manager
>            Reporter: Sumit Agrawal
>            Priority: Critical
>
> As part of *HDDS-8974. Introduce detailed lock information*
> Below omLockDetails is declared which is private to the instance and consume 
> thread local resource of thread. But this resource is never released.
> private final ThreadLocal<OMLockDetails> omLockDetails =
> ThreadLocal.withInitial(OMLockDetails::new);
>  
> This will cause memory leak and thread local memory keeps increasing with 
> each new Request object.
>  
> Need avoid usages of thread local as instance level; or need use as static or 
> as singleton to reuse same resource.
>  
> cc: [~Symious] [~Sammi] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to