adoroszlai commented on code in PR #6238:
URL: https://github.com/apache/ozone/pull/6238#discussion_r1499606262
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/WithObjectID.java:
##########
@@ -22,34 +22,24 @@
/**
* Mixin class to handle ObjectID and UpdateID.
*/
-public class WithObjectID extends WithMetadata {
+public abstract class WithObjectID extends WithMetadata {
Review Comment:
Yes, these are intended to be subclassed, not instantiated. This part of
the change is not critical, though.
`WithParentObjectId` is instantiated in `PrefixParser`, so I couldn't make
it `abstract` without further change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
