swamirishi commented on code in PR #6182: URL: https://github.com/apache/ozone/pull/6182#discussion_r1499614795
########## hadoop-hdds/rocks-native/src/CMakeLists.txt: ########## @@ -21,6 +21,7 @@ # cmake_minimum_required(VERSION 2.8) +add_definitions(-D_GLIBCXX_USE_CXX11_ABI=0) Review Comment: std::string const& is being compiled as std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const& for gcc > 5. But the rocksdbjni shared lib inside the jar has been compiled where strings are compiled as std::string setting -D_GLIBCXX_USE_CXX11_ABI=0 will make it consistent with the lib in the jar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
