raju-balpande commented on code in PR #6247:
URL: https://github.com/apache/ozone/pull/6247#discussion_r1502179867
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestSstFilteringService.java:
##########
@@ -133,19 +129,31 @@ public void cleanup() throws Exception {
* @throws IOException - on Failure.
*/
@Test
- @Order(1)
public void testIrrelevantSstFileDeletion()
throws Exception {
RDBStore activeDbStore = (RDBStore) om.getMetadataManager().getStore();
SstFilteringService filteringService =
keyManager.getSnapshotSstFilteringService();
final int keyCount = 100;
- String volumeName = "vol1";
+ String volumeName = "volz";
Review Comment:
I have to do it because of following lines in
RocksDatabase.java:deleteFilesNotMatchingPrefix();
` String lastDbKey = new String(liveFileMetaData.largestKey(), UTF_8);
boolean isKeyWithPrefixPresent =
RocksDiffUtils.isKeyWithPrefixPresent(
prefixForColumnFamily, firstDbKey, lastDbKey);`
So if I select the volume name prior to existing volume names the non zero
level file will not get clear by process which runs in background as
SstFilteringTask.call().
May be this can be considered as defect in existing code. If you suggest I
can raise it as defect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
