Tejaskriya commented on PR #6179: URL: https://github.com/apache/ozone/pull/6179#issuecomment-1963585428
Through some testing on a branch on my fork, we saw that in certain environments, the thread ignores the interrupted flag when it is yet to go to sleep. CI run in which test runs take 1-7mins: https://github.com/Tejaskriya/ozone/actions/runs/8004080183/job/21860744227 So if the Thread.interrupt() is called before Thread.sleep(), then the interrupt is ignored. This is fixed by retrying the interrupt (as if there is an interrupt when the thread is already sleeping, the interrupt is not ignored). CI run in which fix was implemented and all tests take <1min): https://github.com/Tejaskriya/ozone/actions/runs/8015385744 This fixes the delays caused in both scenarios: 1. Thread sleeping in delayStart before starting 2. Thread sleeping to wait for updated usage information from datanodes @sumitagrawl @sodonnel @adoroszlai please do review the latest changes, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
