sodonnel commented on code in PR #6255:
URL: https://github.com/apache/ozone/pull/6255#discussion_r1502776721
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHealthSchemaManager.java:
##########
@@ -113,6 +118,10 @@ public Cursor<UnhealthyContainersRecord>
getAllUnhealthyRecordsCursor() {
}
public void insertUnhealthyContainerRecords(List<UnhealthyContainers> recs) {
+ recs.forEach(rec -> {
Review Comment:
Should we wrap this in a "if debug enabled" statement? Normally I am against
doing that for a single debug statement, as it is handled inside the logger,
but in this case we will have to iterate all the records and it is pssible
there are a lot of them, so it might be worth wrapping the entire forEach so
avoid that expense if it is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
