adoroszlai opened a new pull request, #6276:
URL: https://github.com/apache/ozone/pull/6276
## What changes were proposed in this pull request?
Missing size suffix in some config properties can prevent Datanode from
starting up:
```
[main] ERROR ozone.HddsDatanodeService: Exception in HddsDatanodeService.
org.apache.hadoop.hdds.conf.ConfigurationException: Failed to inject
configuration to OzoneClientConfig.bytesPerChecksum
at
org.apache.hadoop.hdds.conf.ConfigurationReflectionUtil.setField(ConfigurationReflectionUtil.java:146)
at
org.apache.hadoop.hdds.conf.ConfigurationReflectionUtil.injectConfigurationToObject(ConfigurationReflectionUtil.java:103)
at
org.apache.hadoop.hdds.conf.ConfigurationReflectionUtil.injectConfiguration(ConfigurationReflectionUtil.java:73)
at
org.apache.hadoop.hdds.conf.ConfigurationSource.getObject(ConfigurationSource.java:177)
at
org.apache.hadoop.ozone.container.ec.reconstruction.ECReconstructionCoordinator.<init>(ECReconstructionCoordinator.java:128)
at
org.apache.hadoop.ozone.container.common.statemachine.DatanodeStateMachine.<init>(DatanodeStateMachine.java:223)
at
org.apache.hadoop.ozone.HddsDatanodeService.start(HddsDatanodeService.java:299)
...
at
org.apache.hadoop.ozone.HddsDatanodeService.main(HddsDatanodeService.java:163)
Caused by: java.lang.IllegalArgumentException: 1024 is not in expected
format.Expected format is <number><unit>. e.g. 1000MB
at org.apache.hadoop.hdds.conf.StorageSize.parse(StorageSize.java:61)
at org.apache.hadoop.hdds.conf.ConfigType$7.parse(ConfigType.java:121)
at
org.apache.hadoop.hdds.conf.ConfigurationReflectionUtil.setField(ConfigurationReflectionUtil.java:142)
... 20 more
```
If suffix is not given, use the unit given for the config property (defaults
to bytes).
https://issues.apache.org/jira/browse/HDDS-10423
## How was this patch tested?
Added unit test.
CI:
https://github.com/adoroszlai/ozone/actions/runs/8051537545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
