adoroszlai commented on code in PR #6257:
URL: https://github.com/apache/ozone/pull/6257#discussion_r1503858329
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java:
##########
@@ -62,6 +62,10 @@ public ReplicationType getType() {
public static S3StorageType getDefault(ConfigurationSource config) {
String replicationString = config.get(OzoneConfigKeys.OZONE_REPLICATION);
ReplicationFactor configFactor;
+ if (replicationString == null) {
Review Comment:
I think empty value (`""`) is similar to any other invalid value (e.g.
`"asdf"`), and should be handled the same way. So `== null` check is better
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
