xBis7 commented on PR #4245: URL: https://github.com/apache/ozone/pull/4245#issuecomment-1969358538
`KeyName` refers to the entire path under the bucket while `FileName` refers just to the key, or to put it another way, the last component of the path. We kept the variables the same in the Legacy code so that the tests can easily be compared to FSO. I would suggest doing the same with OBS if it's feasible. To explain it with an example `/vol1/bucket1/dir1/dir2/key1` KeyName: `/dir1/dir2/key1` FileName: `key1` The issue in these tests is that there is no depth in the key structure. That's why all the key names and the file names are the same. Check FSO and Legacy https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java#L135-L159 https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java#L135-L159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
