adoroszlai commented on code in PR #6307:
URL: https://github.com/apache/ozone/pull/6307#discussion_r1508937895
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java:
##########
@@ -95,18 +95,17 @@ public void importContainer(long containerID, Path
tarFilePath,
throws IOException {
if (!importContainerProgress.add(containerID)) {
deleteFileQuietely(tarFilePath);
- LOG.warn("Container import in progress with container Id {}",
- containerID);
- throw new StorageContainerException("Container " +
- "import in progress with container Id " + containerID,
+ String log = "Container import in progress with container Id ";
+ LOG.warn(log + "{}", containerID);
+ throw new StorageContainerException(log + containerID,
ContainerProtos.Result.CONTAINER_EXISTS);
}
try {
if (containerSet.getContainer(containerID) != null) {
- LOG.warn("Container already exists with container Id {}", containerID);
- throw new StorageContainerException("Container already exists " +
- "with container Id " + containerID,
+ String log = "Container already exists with container Id ";
+ LOG.warn(log + "{}", containerID);
+ throw new StorageContainerException(log + containerID,
Review Comment:
Please apply the same logic here.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java:
##########
@@ -95,18 +95,17 @@ public void importContainer(long containerID, Path
tarFilePath,
throws IOException {
if (!importContainerProgress.add(containerID)) {
deleteFileQuietely(tarFilePath);
- LOG.warn("Container import in progress with container Id {}",
- containerID);
- throw new StorageContainerException("Container " +
- "import in progress with container Id " + containerID,
+ String log = "Container import in progress with container Id ";
+ LOG.warn(log + "{}", containerID);
+ throw new StorageContainerException(log + containerID,
Review Comment:
nit: no need for placeholders, since the message string is always created
for the exception.
```suggestion
String log = "Container import in progress with container Id " +
containerID;
LOG.warn(log);
throw new StorageContainerException(log,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
