ashishkumar50 commented on code in PR #6309:
URL: https://github.com/apache/ozone/pull/6309#discussion_r1510655427
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java:
##########
@@ -76,8 +74,11 @@ public class BlockInputStream extends
BlockExtendedInputStream {
private XceiverClientSpi xceiverClient;
private boolean initialized = false;
// TODO: do we need to change retrypolicy based on exception.
- private final RetryPolicy retryPolicy =
- HddsClientUtils.createRetryPolicy(3, TimeUnit.SECONDS.toMillis(1));
+ // Default retry, retry for DN connectivity issues & what else?
+ private final RetryPolicy retryPolicy = getRetryPolicy();
+ //=
+ // HddsClientUtils.createRetryPolicy(3, TimeUnit.SECONDS.toMillis(1));
Review Comment:
Remove commented code.
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -144,6 +144,23 @@ public enum ChecksumCombineMode {
tags = ConfigTag.CLIENT)
private int retryInterval = 0;
+ @Config(key = "max.read.retries",
+ defaultValue = "3",
+ description = "Maximum number of retries by Ozone Client on "
+ + "encountering connectivity exception when reading a key.",
+ tags = ConfigTag.CLIENT)
+ private int maxReadRetryCount = 3;
+
+ @Config(key = "read.retry.interval",
Review Comment:
Currently retry interval is not effective in read retry case.
This has been fixed in feature branch HDDS-7593 and needs to be merged in
master.
https://github.com/apache/ozone/pull/6292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
