whbing commented on code in PR #6268:
URL: https://github.com/apache/ozone/pull/6268#discussion_r1511052255
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/prefix/OMPrefixAclRequest.java:
##########
@@ -145,16 +142,21 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, TermIn
} finally {
if (lockAcquired) {
mergeOmLockDetails(omMetadataManager.getLock()
- .releaseWriteLock(PREFIX_LOCK, getOzoneObj().getPath()));
+ .releaseWriteLock(PREFIX_LOCK, prefixPath));
}
if (omClientResponse != null) {
omClientResponse.setOmLockDetails(getOmLockDetails());
}
}
- OzoneObj obj = getOzoneObj();
+ OzoneObj obj = resolvedPrefixObj;
+ if (obj == null) {
Review Comment:
Is null condition necessary here ? I see a call to
`resolvedPrefixObj.getpath ()` on line 81, 82.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/prefix/OMPrefixAclRequest.java:
##########
@@ -68,28 +66,27 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIn
boolean lockAcquired = false;
String volume = null;
String bucket = null;
- String key = null;
+ String prefix = null;
Review Comment:
`String prefix` or `String prefixPath` maybe only need one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
