szetszwo commented on PR #6303:
URL: https://github.com/apache/ozone/pull/6303#issuecomment-1977547598

   > ...  methods  SCMNodeManager::addPipeline and 
SCMNodeManager::removePipeline are called under write_lock from 
PipelineStateManagerImpl,  ...
   
   I see.  The methods are protected by an external locking in 
`PipelineStateManagerImpl` but not the `computeIfAbsent`/`computeIfPresent` 
methods.  Then, removing `synchronized` is okay.  Thanks for checking!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to