myskov commented on code in PR #6332:
URL: https://github.com/apache/ozone/pull/6332#discussion_r1514065357
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/ContainerClientMetrics.java:
##########
@@ -112,27 +112,27 @@ public void recordWriteChunk(Pipeline pipeline, long
chunkSizeBytes) {
}
@VisibleForTesting
- public MutableCounterLong getTotalWriteChunkBytes() {
+ MutableCounterLong getTotalWriteChunkBytes() {
return totalWriteChunkBytes;
}
@VisibleForTesting
Review Comment:
VisibleForTesting annotation is overused in the codebase. I think a ticket
named "Reduce metrics visibility" is a good chance to put things in order
there, including the annotation.
If removing an annotation doesn't break tests, the annotation is not needed
and should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
