muskan1012 commented on PR #6321:
URL: https://github.com/apache/ozone/pull/6321#issuecomment-1980611987
> While capturing the latencies of `checkKeyACLs` and `resolveBucketLink`
individual calls, you can directly wrap the calls under the `captureLatencyNs`
block (as mentioned in the previous reviews).
>
> For latency capture spanning across multiple lines of code (such as
success/failure operation latencies), you can either use the same lambda
function with the lines of code enclosed under the '`{}`' of the
`captureLatencyNs` block (following code snippet), or it should also be okay to
capture the individual timestamps (you can make a judgement from the
readability perspective).
>
> ```
> captureLatencyNs(metrics.getMetricLatencyNs(), () -> {
> // lines of code to be included whose
> // latency needs to be taken into account.
> }
> ```
Same thing is happening in both resolveBucketLink and checkAcl, in both case
we must need to declare volumeName and bucketName as final to use it with
captureLatencyNs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
