adoroszlai commented on code in PR #84: URL: https://github.com/apache/ozone-site/pull/84#discussion_r1516738454
########## .github/scripts/sidebar.sh: ########## @@ -0,0 +1,48 @@ +#!/usr/bin/env sh +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Validates docusaurus _category_.yml files used to configure the docs sidebar. +# Each docs subdirectory should have a _category_.yml file, and it must follow the defined schema. +# The schema is more restrictive than what Docusaurus allows, and can be used to disallow keys or require all category +# files to define the same keys. + +rc=0 + +root="$(git rev-parse --show-toplevel)" +schema="$root"/.github/resource/category.schema.json + +# Make sure all docs directories have a category sidebar file. +for child in $(find "$root"/docs/*); do + if [ -d "$child" ]; then Review Comment: nit: I think reduce iterations by using `-type d` as in `find "$root"/docs -type d` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
