adoroszlai commented on code in PR #6347:
URL: https://github.com/apache/ozone/pull/6347#discussion_r1517129410
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestStorageContainerManager.java:
##########
@@ -212,7 +211,7 @@ private void testRpcPermissionWithConf(
}
private void testRpcPermission(MiniOzoneCluster cluster,
- String fakeRemoteUsername, boolean expectPermissionDenied) {
+ String fakeRemoteUsername, boolean
expectPermissionDenied) {
Review Comment:
nit: please keep original indent of method parameters (there are a few more
similar cases below)
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestStorageContainerManager.java:
##########
@@ -779,7 +707,7 @@ public void testScmProcessDatanodeHeartbeat() throws
Exception {
conf.setClass(NET_TOPOLOGY_NODE_SWITCH_MAPPING_IMPL_KEY,
StaticMapping.class, DNSToSwitchMapping.class);
StaticMapping.addNodeToRack(NetUtils.normalizeHostNames(
- Collections.singleton(HddsUtils.getHostName(conf))).get(0),
+ Collections.singleton(HddsUtils.getHostName(conf))).get(0),
"/rack1");
Review Comment:
Now I noticed this can be simplified by using `normalizeHostName(String)`
instead of `normalizeHostNames(Collection)`:
```
StaticMapping.addNodeToRack(NetUtils.normalizeHostName(HddsUtils.getHostName(conf)),
"/rack1");
```
Note: `import ...Collections` becomes unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
