adoroszlai commented on code in PR #6349:
URL: https://github.com/apache/ozone/pull/6349#discussion_r1517851359
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -86,57 +86,40 @@ public static Codec<DatanodeDetails> getCodec() {
private String ipAddress;
private String hostName;
- private List<Port> ports;
+ private final List<Port> ports;
private String certSerialId;
private String version;
private long setupTime;
private String revision;
private String buildDate;
private volatile HddsProtos.NodeOperationalState persistedOpState;
- private volatile long persistedOpStateExpiryEpochSec = 0;
+ private volatile long persistedOpStateExpiryEpochSec;
private int initialVersion;
private int currentVersion;
- /**
- * Constructs DatanodeDetails instance. DatanodeDetails.Builder is used
- * for instantiating DatanodeDetails.
- * @param uuid DataNode's UUID
- * @param ipAddress IP Address of this DataNode
- * @param hostName DataNode's hostname
- * @param networkLocation DataNode's network location path
- * @param ports Ports used by the DataNode
- * @param certSerialId serial id from SCM issued certificate.
- * @param version DataNode's version
- * @param setupTime the setup time of DataNode
- * @param revision DataNodes's revision
- * @param buildDate DataNodes's build timestamp
- * @param persistedOpState Operational State stored on DN.
- * @param persistedOpStateExpiryEpochSec Seconds after the epoch the stored
- * state should expire.
- */
- @SuppressWarnings("parameternumber")
- private DatanodeDetails(UUID uuid, String ipAddress, String hostName,
- String networkLocation, List<Port> ports, String certSerialId,
- String version, long setupTime, String revision, String buildDate,
- HddsProtos.NodeOperationalState persistedOpState,
- long persistedOpStateExpiryEpochSec,
- int initialVersion, int currentVersion) {
- super(hostName, networkLocation, NetConstants.NODE_COST_DEFAULT);
- this.uuid = uuid;
- this.uuidString = uuid.toString();
+ private DatanodeDetails(Builder b) {
Review Comment:
Since there is only one parameter, I think `b` is OK. (There are 31 similar
constructors elsewhere.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
