myskov opened a new pull request, #6358:
URL: https://github.com/apache/ozone/pull/6358

   To improve Apache Rat configuration and Ozone maven config, I have done:
   
   * Added Rat plugin to the root module (ozone-main) to cover all files in a 
repo.
   * Removed Rat plugin declarations from other modules to make maven and rat 
configs more readable.
   * Moved exclusions to a separate file to make the Maven config more 
maintainable.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-10498
   
   ## How was this patch tested?
   
   1. I did a manual test by adding a "file.txt" without a license inside to 
hadoop-hdds-client project and running apache-rat:check goal. The output of the 
build:
   
   <pre>
   [INFO] --- apache-rat:0.16.1:check (default-cli) @ hdds-client ---
   [INFO] Rat check: Summary over all files. Unapproved: 1, unknown: 1, 
generated: 0, approved: 68 licenses.
   [WARNING] Files with unapproved licenses:
     /Users/maximmyskov/Projects/github/myskov-ozone/hadoop-hdds/client/file.txt
   </pre>
   2. As the CI script is also modified, I committed the same "file.txt" to the 
branch and got the following output from RAT workflow:
   <pre>
   Run hadoop-ozone/dev-support/checks/_summary.sh target/rat/summary.txt
   
[10](https://github.com/myskov/ozone/actions/runs/8205987100/job/22444088879#step:7:11)
   hadoop-hdds/client/target/rat.txt: !????? 
/home/runner/work/ozone/ozone/hadoop-hdds/client/file.txt
   
[11](https://github.com/myskov/ozone/actions/runs/8205987100/job/22444088879#step:7:12)
   Error: Process completed with exit code 1.
   </pre>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to