ArafatKhan2198 commented on code in PR #6272:
URL: https://github.com/apache/ozone/pull/6272#discussion_r1521039722
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3261,6 +3261,24 @@
fetch loops.
</description>
</property>
+ <property>
+ <name>recon.scm.delta.update.limit</name>
Review Comment:
Could you please define a little more of what these two configs are meant
for in the description.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java:
##########
@@ -1154,4 +1156,31 @@ public String getMetrics(String query) throws
IOException {
String metricsJsonStr = response.getMetricsJson();
return metricsJsonStr;
}
+
+ /**
+ * Get DB updates since a specific sequence number.
+ *
+ * @param dbUpdatesRequest request that encapsulates a sequence number.
+ * @return Wrapper containing the updates.
+ */
+ @Override
+ public DBUpdates
getDBUpdates(StorageContainerLocationProtocolProtos.DBUpdatesRequestProto
dbUpdatesRequest)
+ throws IOException {
+
+ StorageContainerLocationProtocolProtos.DBUpdatesResponseProto
dbUpdatesResponse =
+ submitRequest(Type.DBUpdates,
+ builder -> builder.setDbUpdatesRequest(dbUpdatesRequest))
Review Comment:
After looking at the getDBUpdates of the OM code we are using a limit should
we implement the same
here?https://github.com/apache/ozone/blob/d68ea97e02995784244f91939cceac404c689e53/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L4194
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java:
##########
@@ -1154,4 +1156,31 @@ public String getMetrics(String query) throws
IOException {
String metricsJsonStr = response.getMetricsJson();
return metricsJsonStr;
}
+
+ /**
+ * Get DB updates since a specific sequence number.
+ *
+ * @param dbUpdatesRequest request that encapsulates a sequence number.
+ * @return Wrapper containing the updates.
+ */
+ @Override
+ public DBUpdates
getDBUpdates(StorageContainerLocationProtocolProtos.DBUpdatesRequestProto
dbUpdatesRequest)
+ throws IOException {
+
+ StorageContainerLocationProtocolProtos.DBUpdatesResponseProto
dbUpdatesResponse =
+ submitRequest(Type.DBUpdates,
+ builder -> builder.setDbUpdatesRequest(dbUpdatesRequest))
Review Comment:
Should we log the error if the request fails?
```
try {
StorageContainerLocationProtocolProtos.DBUpdatesResponseProto
dbUpdatesResponse =
submitRequest(Type.DBUpdates,
builder -> builder.setDbUpdatesRequest(dbUpdatesRequest))
.getDbUpdatesResponse();
} catch (Exception e) {
throw new IOException("Failed to get DB updates due to an error.", e);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
